Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the const_cast from SiStripFedCablingFakeESSource #41121

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Remove the const_cast from SiStripFedCablingFakeESSource #41121

merged 1 commit into from
Mar 22, 2023

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Mar 21, 2023

PR description:

The SA reported that the

/CalibTracker/SiStripESProducers/plugins/fake/SiStripFedCablingFakeESSource.cc
has a const_cast which is not thread safe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-480837/31402/llvm-analysis/report-69c66f.html#EndPath

This PR (by Marco) resolves that.

PR validation:

Payload produced by SiStripFedCablingBuilder_cfg.py has the same content as before the PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is needed.

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Mar 21, 2023
@tvami
Copy link
Contributor Author

tvami commented Mar 21, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41121/34760

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CalibTracker/SiStripESProducers (alca)

@tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 21, 2023

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Mar 21, 2023

test parameters:

  • addpkg = CondTools/SiStrip

@mmusich
Copy link
Contributor

mmusich commented Mar 21, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f013/31493/summary.html
COMMIT: 3ea00a5
CMSSW: CMSSW_13_1_X_2023-03-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41121/31493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550915
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550883
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Mar 21, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b4eb56 into cms-sw:master Mar 22, 2023
@mmusich mmusich mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@tvami @cmsbuild @mmusich @perrotta